Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support create LB with existing network/subnet #428

Closed
jichenjc opened this issue Aug 8, 2019 · 9 comments
Closed

support create LB with existing network/subnet #428

jichenjc opened this issue Aug 8, 2019 · 9 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@jichenjc
Copy link
Contributor

jichenjc commented Aug 8, 2019

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
this is a use case at least in my env , you are not authorized to create network/subnet due to restriction on the system ,then you have to reuse existing network to create LB,
however, under current implementation we don't allow this use case, you have to create a new network by using the nodeCIDR setting.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 8, 2019
@jichenjc
Copy link
Contributor Author

jichenjc commented Aug 8, 2019

/assign

@jichenjc
Copy link
Contributor Author

to add more info here:

  1. some times there is no floating ip needed, e.g someone is using provider network and we need make that as least works without floating ip introduction
  2. with 1) above, you don't need create a nodecidr in order to work, some existing network can be specified in order to make cluster api to create..

@sbueringer
Copy link
Member

So we'll implement it like I proposed here?
#422 (comment)

@sbueringer
Copy link
Member

I would open a PR to fix this, if it's okay :)

@jichenjc
Copy link
Contributor Author

sure, I am too busy recently on other things. so please go ahead and push PR, thanks ~

@sbueringer
Copy link
Member

/assign @sbueringer
PR is open here: #475

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 23, 2019
@sbueringer
Copy link
Member

Was fixed in #477

/close

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closing this issue.

In response to this:

Was fixed in #477

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
4 participants