Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix cluster-template.yaml #534

Merged
merged 1 commit into from
Apr 3, 2020
Merged

🐛 Fix cluster-template.yaml #534

merged 1 commit into from
Apr 3, 2020

Conversation

hidekazuna
Copy link
Contributor

What this PR does / why we need it:

This PR updates cluster-template.yaml to work.
OpenStack environment needs the followings.

  • Port security feature to use OpenStack Octavia with HAProxy Amphora.
  • Appropriate security groups to master and worker nodes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 1, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 1, 2020
@jichenjc
Copy link
Contributor

jichenjc commented Apr 1, 2020 •
edited
Loading

/approve

I didn't test it locally but code looks as reasonable change
a question is whether this sec group thing is also included in e2e test or can be added?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hidekazuna, jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2020
@hidekazuna hidekazuna mentioned this pull request Apr 1, 2020
Merged
@hidekazuna
Copy link
Contributor Author

a question is whether this sec group thing is also included in e2e test or can be added?

e2e conformance.sh only tests cluster-template-without-lb.yaml.
https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/master/hack/ci/e2e-conformance.sh#L29

@jichenjc
Copy link
Contributor

jichenjc commented Apr 1, 2020

thanks ,I will dig more here as I think sec group is not related to lb or without lb...

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 1, 2020

Build failed.

@sbueringer
Copy link
Member

recheck

@sbueringer
Copy link
Member

thanks ,I will dig more here as I think sec group is not related to lb or without lb...

Port security is mandatory for Octavia and with port security and without sec groups nothing works

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 1, 2020

Build failed.

@sbueringer
Copy link
Member

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2020
@sbueringer
Copy link
Member

recheck

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2020
@sbueringer
Copy link
Member

@hidekazuna sorry for the e2e test. You have an about 50% chance that it gets green depending on on which OpenStack cluster it is executed. I'm working on it. There's also an PR which I hoped that it's already merged to ignore OpenLab tests for merges: kubernetes/test-infra#16990

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 2, 2020

Build succeeded.

@sbueringer
Copy link
Member

@hidekazuna Also verified it locally via devstack. lgtm! :)

@jichenjc
Copy link
Contributor

jichenjc commented Apr 3, 2020

/hold cancel
I think we are good to go

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 03c8494 into kubernetes-sigs:master Apr 3, 2020
@hidekazuna hidekazuna mentioned this pull request Jun 15, 2020
Closed
@hidekazuna hidekazuna deleted the fix_cluster-template branch July 3, 2020 08:32
@hidekazuna hidekazuna mentioned this pull request Jul 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer requested changes

@dims dims Awaiting requested review from dims

@m1093782566 m1093782566 Awaiting requested review from m1093782566

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hidekazuna @jichenjc @k8s-ci-robot @sbueringer