Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc for how to move a cluster #630

Merged
merged 1 commit into from Oct 15, 2020
Merged

Add doc for how to move a cluster #630

merged 1 commit into from Oct 15, 2020

Conversation

jichenjc
Copy link
Contributor

@jichenjc jichenjc commented Sep 1, 2020

What this PR does / why we need it:
Add a doc on how to move a cluster

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 1, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 1, 2020

Build failed.

@jichenjc
Copy link
Contributor Author

jichenjc commented Sep 2, 2020

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 2, 2020

Build failed.

@jichenjc
Copy link
Contributor Author

jichenjc commented Sep 3, 2020

@hidekazuna @sbueringer take a look? The CI is not stable now (theopenlab/openlab#581) but this is doc only change...

@hidekazuna
Copy link
Contributor

@jichenjc Moving cluster is nothing special except for #626 . IMO we do not need documentation about moving once we resolve #626 .

@jichenjc
Copy link
Contributor Author

jichenjc commented Sep 7, 2020

well.. I think it's still helpful to give an end to end sample ..

@hidekazuna
Copy link
Contributor

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 12, 2020

Build succeeded.

@hidekazuna
Copy link
Contributor

@jichenjc Please update using clusterctl.cluster.x-k8s.io/move.

@jichenjc
Copy link
Contributor Author

@hidekazuna updated, thanks~

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 13, 2020

Build failed.

hidekazuna
hidekazuna suggested changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@hidekazuna hidekazuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use "OpenStack", not "openstack".

docs/configuration.md Outdated
@@ -84,6 +84,8 @@ The following variables are set.

Note: Only the [external cloud provider](./external-cloud-provider.md) supports [Application Credentials](https://docs.openstack.org/keystone/latest/user/application_credentials.html).

Note: you need set `clusterctl.cluster.x-k8s.io/move` label for the secret created from `OPENSTACK_CLOUD_YAML_B64` in order to successfully move objects from bootstrap cluster to target cluster. See [bug 626](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/issues/626) for further information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to set

docs/mover.md Outdated

<!-- END doctoc generated TOC please keep comment here to allow auto update -->

This documenation describe how to move `cluster-api` related objects from `bootstrap` cluster to `target` cluster. check [clusterctl move](https://cluster-api.sigs.k8s.io/clusterctl/commands/move.html) for further info.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation describes how to move Cluster API related objects from bootstrap cluster to target cluster. Check clusterctl move for further info.

docs/mover.md Outdated

# Install openstack providers into target cluster

You need install openstack cluster api providers into `target` cluster first.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to install OpenStack Cluster API provider into target cluster first.

docs/mover.md Outdated
clusterctl config cluster [name] --kubernetes-version [version] | kubectl apply -f -
```

# Move objects in `bootstrap` cluster into `target` cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move objects from bootstrap cluster into target cluster

docs/mover.md Outdated

# Pre-condition

bootstrap cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bootstrap cluster

docs/mover.md Outdated
local-path-storage local-path-provisioner-bd4bb6b75-ft7wh 1/1 Running 0 40m
```

target cluster (using external cloud manager)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Target cluster (Below is an example of external cloud provider)

docs/mover.md Outdated
kube-system openstack-cloud-controller-manager-z9jtc 1/1 Running 1 4m9s
```

# Install openstack providers into target cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install OpenStack Cluster API provider into target cluster

@jichenjc
Copy link
Contributor Author

@hidekazuna update. thanks

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 14, 2020

Build failed.

@jichenjc
Copy link
Contributor Author

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 14, 2020

Build failed.

@hidekazuna
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit fac3755 into kubernetes-sigs:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidekazuna hidekazuna hidekazuna requested changes

@gyliu513 gyliu513 Awaiting requested review from gyliu513

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@hidekazuna hidekazuna

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jichenjc @k8s-ci-robot @hidekazuna