Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vSphere] Store provider config variables in secrets #9

Closed
roberthbailey opened this issue Aug 17, 2018 · 2 comments · Fixed by #250
Closed

[vSphere] Store provider config variables in secrets #9

roberthbailey opened this issue Aug 17, 2018 · 2 comments · Fixed by #250
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
0.3

Comments

@roberthbailey
Copy link
Contributor

From @karan on May 29, 2018 17:13

This is for security and safety, since the provider config blob can contain sensitive credentials.

/kind feature

/assign @karan

Copied from original issue: kubernetes-sigs/cluster-api#226
@k8s-ci-robot
Copy link
Contributor

@roberthbailey: GitHub didn't allow me to assign the following users: karan.

Note that only kubernetes-sigs members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

From @karan on May 29, 2018 17:13

This is for security and safety, since the provider config blob can contain sensitive credentials.

/kind feature

/assign @karan

Copied from original issue: kubernetes-sigs/cluster-api#226

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 17, 2018
@roberthbailey
Copy link
Contributor Author

From @karan on May 31, 2018 23:45

After a little more thought, this might not work since the provider config will still need to exist on the objects. So we can't actually have them only in secrets.

@roberthbailey roberthbailey mentioned this issue Aug 17, 2018
Closed
@sflxn sflxn added this to the Next milestone Jan 31, 2019
@sflxn sflxn mentioned this issue Feb 1, 2019
Closed
@sidharthsurana sidharthsurana mentioned this issue Feb 4, 2019
Closed
@sidharthsurana sidharthsurana mentioned this issue Apr 18, 2019
Merged
@sidharthsurana sidharthsurana modified the milestones: Next, 0.3 Apr 18, 2019
k8s-ci-robot pushed a commit that referenced this issue Apr 19, 2019
@sidharthsurana @k8s-ci-robot
Add support for specifying vsphere credentials via secrets (#250)
b5ce311 
- Adds new field vsphereCredentialSecret that can be specified to
  point to the secret that holds the credentials

Resolves #9

Change-Id: I8e43864302a51386f7f11725b0a966cc9e436c59
odvarkadaniel pushed a commit to odvarkadaniel/cluster-api-provider-vsphere that referenced this issue Oct 17, 2023
@openshift-merge-robot
Merge pull request kubernetes-sigs#9 from openshift-cloud-team/update…
bd58742 
…-owners

Update OWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
0.3
Development

Successfully merging a pull request may close this issue.

Add support for specifying vsphere credentials via secrets
4 participants
@sflxn @sidharthsurana @roberthbailey @k8s-ci-robot