Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vSphere] Store provider config variables in secrets #226

Closed
karan opened this issue May 29, 2018 · 2 comments
Closed

[vSphere] Store provider config variables in secrets #226

karan opened this issue May 29, 2018 · 2 comments
Assignees
@karan
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@karan
Copy link
Contributor

karan commented May 29, 2018 •
edited
Loading

This is for security and safety, since the provider config blob can contain sensitive credentials.

/kind feature

/assign @karan
@karan
Copy link
Contributor Author

karan commented May 31, 2018

After a little more thought, this might not work since the provider config will still need to exist on the objects. So we can't actually have them only in secrets.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 1, 2018
@roberthbailey roberthbailey mentioned this issue Aug 17, 2018
Closed
@roberthbailey
Copy link
Contributor

This issue was moved to kubernetes-sigs/cluster-api-provider-vsphere#9

chuckha pushed a commit to chuckha/cluster-api that referenced this issue Oct 2, 2019
@k8s-ci-robot
Merge pull request kubernetes-sigs#226 from joonas/add-make-help
0823568 
🏃‍♂️ Add 'help' target to Makefile and make it the default
chuckha pushed a commit to chuckha/cluster-api that referenced this issue Oct 2, 2019
@k8s-ci-robot
Merge pull request kubernetes-sigs#226 from Nordix/bugfix/kubeadmCont…
093a241 
…roller-issue214

🐛 Fix error-return for machine-cluster association
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this issue Jan 31, 2020
@k8s-ci-robot
Resolved an annotation name changed (kubernetes-sigs#226)
1b314e2 
For the node controller to update a machine's noderef, the node must have
an annotation cluster.k8s.io/machine=${MACHINE}.  CAPV's template currently
is adding that annotation with name 'machine' instead of 'cluster.k8s.io/machine'.
This change should allow the node controller to add a noderef to machine
objects.

Resolves kubernetes-sigs#223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karan karan

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karan @roberthbailey @k8s-ci-robot