Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add checks for network validation on update in vSphereMachine #1192

Merged
merged 1 commit into from
Jun 7, 2021
Merged

add checks for network validation on update in vSphereMachine #1192

merged 1 commit into from
Jun 7, 2021

Conversation

MaxRink
Copy link
Contributor

@MaxRink MaxRink commented Jun 2, 2021

What this PR does / why we need it:

This adds checks so that networks in vSpherMachines are also validated on update and not just on create

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:

none

Release note:

Validate vSphereMachine Network assignment also upon update, not just on create

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 2, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @MaxRink. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 2, 2021
@MaxRink
Copy link
Contributor Author

MaxRink commented Jun 2, 2021

should i also backport that to alpha3?
I dont think that would make a breaking change, give that VMs that would pass before are broken anyway, as the network config will never be applied properly

@gab-satchi
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2021
gab-satchi
gab-satchi approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@gab-satchi gab-satchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm. Thanks! and yes we could backport to v1a3 as well.

api/v1alpha4/vspheremachine_webhook.go Outdated Show resolved Hide resolved
@MaxRink MaxRink mentioned this pull request Jun 3, 2021
Merged
@MaxRink
Copy link
Contributor Author

MaxRink commented Jun 3, 2021

#1194 is for alpha3

@MaxRink MaxRink force-pushed the check_for_valid_ip_in_vSphereVM branch from f47e580 to 20963ba Compare June 3, 2021 15:15
@gab-satchi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2021
yastij
yastij approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 34bbb00 into kubernetes-sigs:master Jun 7, 2021
k8s-ci-robot added a commit that referenced this pull request Jun 7, 2021
@k8s-ci-robot
Merge pull request #1194 from MaxRink/validate-ipaddr-a3
2db68bd 
add checks for network validation on update in vSphereMachine #1192 of a3
@MaxRink MaxRink deleted the check_for_valid_ip_in_vSphereVM branch June 7, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gab-satchi gab-satchi gab-satchi approved these changes

@yastij yastij yastij approved these changes

@chuckha chuckha Awaiting requested review from chuckha

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@gab-satchi gab-satchi

@yastij yastij

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaxRink @k8s-ci-robot @gab-satchi @yastij