Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace GC_KIND variable with SKIP_RESOURCE_CLEANUP #1446

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Replace GC_KIND variable with SKIP_RESOURCE_CLEANUP #1446

merged 1 commit into from
Feb 28, 2022

Conversation

geetikabatra
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 17, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @geetikabatra. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 17, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 17, 2022
@geetikabatra geetikabatra changed the title Gc kind Replace GC_KIND variable with SKIP_RESOURCE_CLEANUP Feb 17, 2022
srm09
srm09 reviewed Feb 17, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
srm09
srm09 reviewed Feb 17, 2022
View reviewed changes
Copy link
Contributor

@srm09 srm09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor nit

@srm09
Copy link
Contributor

srm09 commented Feb 18, 2022

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: srm09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2022
@srm09
Copy link
Contributor

srm09 commented Feb 22, 2022

Could you include the description of the new flag in the https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/tree/master/test/e2e#running-the-e2e-tests section?

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 23, 2022
srm09
srm09 requested changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@srm09 srm09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments and squash the commits, and this is ready to merge after.

test/e2e/README.md Outdated Show resolved Hide resolved
test/e2e/README.md Outdated Show resolved Hide resolved
sigs.k8s.io/cluster-api-provider-vsphere/apis/v1alpha3/zz_generated.conversion.go Outdated Show resolved Hide resolved
sigs.k8s.io/cluster-api-provider-vsphere/apis/v1alpha4/zz_generated.conversion.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 25, 2022
@srm09
Copy link
Contributor

srm09 commented Feb 25, 2022

Do squash the commits before this can be merged.

@geetikabatra
Replace GC_KIND variable with SKIP_RESOURCE_CLEANUP
0f99561 
Updating GC_KIND variable with SKIP_RESOURCE_CLEANUP.
This variable is used to tear down the cluster after
runnning e2e tests.

Signed-off-by: geetikab@vmware.com <geetikab@vmware.com>

This is a combimation of 6 commits.

Update Makefile

Co-authored-by: Sagar Muchhal <8758225+srm09@users.noreply.github.com>

Add description of the flag

This commit adds description of the flag 'SKIP_RESOURCE_CLEANUP'

Signed-off-by: geetikab@vmware.com <geetikab@vmware.com>

Update test/e2e/README.md

Co-authored-by: Sagar Muchhal <8758225+srm09@users.noreply.github.com>

Remove autogenerated files

This change removes the autogenerated files.

Signed-off-by: geetikab@vmware.com <geetikab@vmware.com>

Update the flag description for SKIP_RESOURCE_CLEANUP
@geetikabatra
Copy link
Contributor Author

Done!

@srm09
Copy link
Contributor

srm09 commented Feb 28, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit fae6ef8 into kubernetes-sigs:master Feb 28, 2022
@srm09 srm09 mentioned this pull request Feb 28, 2022
Merged
@ditsuke ditsuke mentioned this pull request Mar 2, 2022
Closed
@geetikabatra geetikabatra mentioned this pull request Jul 4, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srm09 srm09 srm09 requested changes

@MaxRink MaxRink Awaiting requested review from MaxRink

Assignees

@srm09 srm09

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@geetikabatra @k8s-ci-robot @srm09