Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add USE_EXISTING_CLUSTER variable for e2e tests #1453

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Add USE_EXISTING_CLUSTER variable for e2e tests #1453

merged 1 commit into from
Mar 2, 2022

Conversation

ditsuke
Copy link
Contributor

@ditsuke ditsuke commented Feb 20, 2022

What this PR does / why we need it

Adds USE_EXISTING_CLUSTER as an environment variable to the Makefile. This variable is passed to the e2e test command where it enables using an existing cluster instead of creating a new one.:

Which issue(s) this PR fixes:
Fixes #1439.

Special notes for your reviewer:
nil

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 20, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 20, 2022 •
edited

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 20, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @ditsuke!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-vsphere 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-vsphere has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 20, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @ditsuke. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2022
@ditsuke ditsuke force-pushed the add-e2e-existing-cluster-variable-1439 branch from 176e7ee to 204873c Compare February 20, 2022 07:12
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 20, 2022
@ditsuke ditsuke force-pushed the add-e2e-existing-cluster-variable-1439 branch from 204873c to 4fb5a5a Compare February 20, 2022 07:21
@aartij17
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 20, 2022
@aartij17
Copy link
Contributor

/test all

@geetikabatra
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@geetikabatra: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@srm09
Copy link
Contributor

srm09 commented Feb 28, 2022

@ditsuke Can you add a doc entry similar to the one in #1446
Otherwise /lgtm

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2022
@ditsuke ditsuke force-pushed the add-e2e-existing-cluster-variable-1439 branch from 4fb5a5a to 1bed405 Compare March 1, 2022 04:04
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2022
@ditsuke
Copy link
Contributor Author

ditsuke commented Mar 1, 2022

@srm09
I've rebased to fae6ef8 and added the doc entry.

srm09
srm09 reviewed Mar 1, 2022
View reviewed changes
Copy link
Contributor

@srm09 srm09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change before this ready for merge. Would you be able to squash your commits into a single one?

test/e2e/README.md Outdated Show resolved Hide resolved
@ditsuke
Add USE_EXISTING_CLUSTER variable for e2e tests
82cd80c 
Adds `USE_EXISTING_CLUSTER` as an environment variable to the Makefile.
This variable is passed to the e2e test command where it enables using
an existing cluster instead of creating a new one.

Signed-off-by: ditsuke <ditsuke@protonmail.com>

Add doc entry for the `USE_EXISTING_CLUSTER` e2e flag

Add default value for the e2e USE_EXISTING_CLUSTER
@ditsuke ditsuke force-pushed the add-e2e-existing-cluster-variable-1439 branch from 1bed405 to 82cd80c Compare March 1, 2022 11:06
@srm09
Copy link
Contributor

srm09 commented Mar 1, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: srm09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2022
@srm09
Copy link
Contributor

srm09 commented Mar 2, 2022

/test all
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 054e81b into kubernetes-sigs:main Mar 2, 2022
@ditsuke ditsuke deleted the add-e2e-existing-cluster-variable-1439 branch March 3, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srm09 srm09 srm09 left review comments

@vrabbi vrabbi Awaiting requested review from vrabbi

Assignees

@srm09 srm09

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose e2e startup variables in the Makefile
5 participants
@ditsuke @k8s-ci-robot @aartij17 @geetikabatra @srm09