✨ Remove previously deprecated code #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
Ankitasw
changed the title
Ankitasw
changed the title
Ankitasw
force-pushed
the
pre-release-1.9-branch-prep
branch
from
c1b6d03
to
3b3e99f
Compare
Ankitasw
changed the title
|
/test ? |
|
@Ankitasw: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-provider-vsphere-e2e-full-main |
chrischdi
reviewed
Oct 23, 2023
Ankitasw
force-pushed
the
pre-release-1.9-branch-prep
branch
from
3b3e99f
to
047afcc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2451 +/- ##
==========================================
+ Coverage 62.83% 62.85% +0.02%
==========================================
Files 122 122
Lines 8763 8753 -10
==========================================
- Hits 5506 5502 -4
+ Misses 2863 2858 -5
+ Partials 394 393 -1
☔ View full report in Codecov by Sentry. |
Ankitasw
changed the title
Ankitasw
force-pushed
the
pre-release-1.9-branch-prep
branch
2 times, most recently
from
e3df956
to
961b7f0
Compare
k8s-ci-robot
added
size/M
Ankitasw
force-pushed
the
pre-release-1.9-branch-prep
branch
4 times, most recently
from
384f1c5
to
b40146a
Compare
Ankitasw
force-pushed
the
pre-release-1.9-branch-prep
branch
from
b40146a
to
99799d7
Compare
Ankitasw
force-pushed
the
pre-release-1.9-branch-prep
branch
from
99799d7
to
f62d591
Compare
Ankitasw
force-pushed
the
pre-release-1.9-branch-prep
branch
from
f62d591
to
e50316a
Compare
k8s-ci-robot
added
size/L
7 tasks
|
Thx! /lgtm /assign @killianmuldoon @chrischdi |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 23bf3b14b0cd30f8979462ebbcaf1b961b58d53b
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR addresses following to prepare main branch for release-1.9:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #2394
Part of #2207