Remove legacy labels and handling

[killianmuldoon]

There's a number labels in the CAPV codebase related to older APIVersions that should be removed along with the code that handles transitioning them.

We have:

• Added in 🐛 Delete legacy finalizer, fix setting ownerRef for VSphereClusterIdentity  #1486
  

  cluster-api-provider-vsphere/controllers/vspherecluster_reconciler.go

  Line 58 in 653d6e9

  const legacyIdentityFinalizer string = "identity/infrastructure.cluster.x-k8s.io"

• Added in 🌱 Re-introduces legacy default network label selector #1536
  

  cluster-api-provider-vsphere/pkg/services/network/constants.go

  Line 37 in 653d6e9

  legacyDefaultNetworkLabel = "capw.vmware.com/is-default-network"

• Added in Add legacy capw labels to VirtualMachine for backward compatibility #1483
  

  cluster-api-provider-vsphere/pkg/services/vmoperator/control_plane_endpoint.go

  Lines 53 to 54 in 09ff688

  	legacyClusterSelectorKey = "capw.vmware.com/cluster.name"
  	legacyNodeSelectorKey = "capw.vmware.com/cluster.role"

These PRs were all introduced in CAPV v1.2.0 https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/releases/tag/v1.2.0 and were introduced as part of the v1beta1 API.

Each of the above were introduced with the explicit legacy prefix, and none are public go variables.

v1.9.0 is 7 releases down the line from when these were introduced and I think we should consider removing them now.

[killianmuldoon]

@lubronzhan in #1483 you said that legacyNodeSelectorKey and legacyClusterSelectorKey labels should be around for one or two releases, but you were waiting for more input. Do you think it's safe to get rid of these, and the others, in CAPV's next release?

[Ankitasw]

legacyIdentityFinalizer would be removed as part of this PR.

[lubronzhan]

Hi @killianmuldoon , I think it's ok to deprecate it now since clusters have been upgraded to newer version. Let me create a PR to remove the legacy one

[killianmuldoon]

Hi @killianmuldoon , I think it's ok to deprecate it now since clusters have been upgraded to newer version. Let me create a PR to remove the legacy one

I think we're getting mixed messages on this from some folks downstream - we've decided to keep these labels around for the time being.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[sbueringer]

/remove-lifecycle stale