Skip to content

Commit

Permalink
Merge pull request #9163 from killianmuldoon/pr-release-note-bug
Browse files Browse the repository at this point in the history
🐛 Generate warning when release notes can not be generated
  • Loading branch information
k8s-ci-robot committed Aug 10, 2023
2 parents 98fa0ca + 92f1e9a commit bc9c48a
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion hack/tools/release/notes.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ var (
unknown,
}

repo = flag.String("repository", "kubernetes-sigs/cluster-api", "The tag or commit to start from.")
repo = flag.String("repository", "kubernetes-sigs/cluster-api", "The repo to run the tool from.")

fromTag = flag.String("from", "", "The tag or commit to start from.")

Expand Down Expand Up @@ -447,6 +447,9 @@ func modifyEntryTitle(title string, prefixes []string) string {
// generateReleaseNoteEntry processes a commit into a PR line item for the release notes.
func generateReleaseNoteEntry(c *commit) (*releaseNoteEntry, error) {
entry := &releaseNoteEntry{}
if c.body == "" {
c.body = "ERROR: BODY MISSING. FIX MANUALLY"
}
entry.title = trimTitle(c.body)
var fork string

Expand Down

0 comments on commit bc9c48a

Please sign in to comment.