Eliminate possible deadlocks in ClusterCacheTracker

Switch to a single lock in ClusterCacheTracker to eliminate possible deadlocks when simultaneously deleted & recreating a client/cache for the same cluster. Signed-off-by: Andy Goldstein <goldsteina@vmware.com>
kubernetes-sigs · Sep 18, 2020 · f881755 · f881755
1 parent b545ca1
commit f881755
Show file tree

Hide file tree

Showing 7 changed files with 406 additions and 911 deletions.
diff --git a/controllers/machinehealthcheck_controller.go b/controllers/machinehealthcheck_controller.go
@@ -404,6 +404,7 @@ func (r *MachineHealthCheckReconciler) watchClusterNodes(ctx context.Context, cl
 	}
 
 	if err := r.Tracker.Watch(ctx, remote.WatchInput{
+		Name:         "machinehealthcheck-watchClusterNodes",
 		Cluster:      util.ObjectKey(cluster),
 		Watcher:      r.controller,
 		Kind:         &corev1.Node{},