Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs about deleting specific machines when downscaling #10306

Open
kranurag7 opened this issue Mar 25, 2024 · 5 comments
Open

add docs about deleting specific machines when downscaling #10306

kranurag7 opened this issue Mar 25, 2024 · 5 comments
Assignees
Labels
area/documentation Issues or PRs related to documentation help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@kranurag7
Copy link
Contributor

What would you like to be added (User Story)?

As an operator, I want to downscale the number of machines but I want to remove certain machines only.

Consider a case where I've 10 machines object and I want to remove only 3 specific machines.

Detailed Description

As of now, I think CAPI docs doesn't cover this part.

Ref: https://main.cluster-api.sigs.k8s.io/tasks/automated-machine-management/scaling.html#scaling-nodes

I searched in slack and found the following information.

NOTE: The annotation doesn't need a value and we can use empty string as well. "cluster.x-k8s.io/delete-machine" : ""

Anything else you would like to add?

happy to send a patch once it's triaged.

Label(s) to be applied

/kind feature
/area documentation

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/documentation Issues or PRs related to documentation needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 25, 2024
@Sunnatillo
Copy link
Contributor

sounds interesting, and it is valid for us a provider as well.

@fabriziopandini fabriziopandini added kind/documentation Categorizes issue or PR as related to documentation. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Mar 29, 2024
@fabriziopandini
Copy link
Member

/triage accepted
/help

@kranurag7 It will be great if you can improve https://main.cluster-api.sigs.k8s.io/tasks/automated-machine-management/scaling.html#scaling-nodes

NOTE: we have https://main.cluster-api.sigs.k8s.io/reference/labels_and_annotations, but I agree that putting all the info relevant for scaling in a single place is valuable

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/triage accepted
/help

@kranurag7 It will be great if you can improve https://main.cluster-api.sigs.k8s.io/tasks/automated-machine-management/scaling.html#scaling-nodes

NOTE: we have https://main.cluster-api.sigs.k8s.io/reference/labels_and_annotations, but I agree that putting all the info relevant for scaling in a single place is valuable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 29, 2024
@kranurag7
Copy link
Contributor Author

/assign

@fabriziopandini
Copy link
Member

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants