KubeadmControlPlane validation should match kubebuilder validation patterns

[ncdc]

The validation for KubeadmControlPlane should be updated to match the patterns shown in https://book.kubebuilder.io/cronjob-tutorial/webhook-implementation.html. Specifically, it should look like this:

var allErrs field.ErrorList

if err := someValidation(); err != nil {
  allErrs = append(allErrs, err)
}
// more validations here

if len(allErrs) == 0 {
  return nil
}

return apierrors.NewInvalid(
  GroupVersion.WithKind("KubeadmControlPlane").GroupKind(),
  r.Name, allErrs)

/kind cleanup
/help
/good-first-issue
/milestone v0.3.0
/priority important-soon

[k8s-ci-robot]

@ncdc:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

The validation for KubeadmControlPlane should be updated to match the patterns shown in https://book.kubebuilder.io/cronjob-tutorial/webhook-implementation.html. Specifically, it should look like this:

var allErrs field.ErrorList

if err := someValidation(); err != nil {
 allErrs = append(allErrs, err)
}
// more validations here

if len(allErrs) == 0 {
 return nil
}

return apierrors.NewInvalid(
 GroupVersion.WithKind("KubeadmControlPlane").GroupKind(),
 r.Name, allErrs)

/kind cleanup
/help
/good-first-issue
/milestone v0.3.0
/priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[neeleshkorade]

I would like to work on this if no one else is working on it yet. Looking to start contributing to cluster-api as much as I can. Thanks

[ncdc]

@neeleshkorade you got it, thanks! Please add a comment /lifecycle active when you start working on it. I'm going to assign it to myself so it's "taken".

/assign