Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calico Manifest assumes Service IP range #324

Closed
krousey opened this issue Jun 11, 2018 · 5 comments
Closed

Calico Manifest assumes Service IP range #324

krousey opened this issue Jun 11, 2018 · 5 comments
Labels
area/provider/vmware Issues or PRs related to vmware provider

Comments

@krousey
Copy link
Contributor

krousey commented Jun 11, 2018

A Calico manifest has a hard-coded service IP that makes an assumption that it falls within the cluster's service cidr. This assumption is made

etcd_endpoints: "http://10.96.232.136:6666"
and
clusterIP: 10.96.232.136

This needs to be an address that falls withing the cluster's Service CIDR because it can be changed by the end-user here

/kind cluster-api-vsphere
/cc @karan

@karan
Copy link
Contributor

karan commented Jun 11, 2018

/assign @satyasm

@k8s-ci-robot
Copy link
Contributor

@karan: GitHub didn't allow me to assign the following users: satyasm.

Note that only kubernetes-sigs members and repo collaborators can be assigned.

In response to this:

/assign @satyasm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@karan
Copy link
Contributor

karan commented Jun 11, 2018

/cc @cadmuxe @satyasm

@cadmuxe
Copy link
Contributor

cadmuxe commented Jun 11, 2018

Thanks, I will create a patch.

@roberthbailey
Copy link
Contributor

This issue was moved to kubernetes-sigs/cluster-api-provider-vsphere#8

jayunit100 pushed a commit to jayunit100/cluster-api that referenced this issue Jan 31, 2020
…ional

clusterctl: VM folder should be optional
@killianmuldoon killianmuldoon added the area/provider/vmware Issues or PRs related to vmware provider label May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/vmware Issues or PRs related to vmware provider
Projects
None yet
Development

No branches or pull requests

6 participants