VMware: support VM images that come with container runtime pre-installed #79
Labels
area/provider/vmware
Issues or PRs related to vmware provider
Comments
|
/cc @karan Karan - can you update this issue based on the current implementation using Ubuntu images? |
|
Currently, we disregard user preference and install docker anyways - https://github.com/kubernetes-sigs/cluster-api/blob/master/cloud/terraform/templates.go#L251 (terraform) and https://github.com/kubernetes-sigs/cluster-api/blob/master/gcp-deployer/machine_setup_configs.yaml#L40 (gcp) |
|
This issue was moved to kubernetes-sigs/cluster-api-provider-vsphere#11 |
chuckha
pushed a commit
to chuckha/cluster-api
that referenced
this issue
Oct 2, 2019
Fix the name of the image in the github action
chuckha
pushed a commit
to chuckha/cluster-api
that referenced
this issue
Oct 2, 2019
Fix up image restart process
jayunit100
pushed a commit
to jayunit100/cluster-api
that referenced
this issue
Jan 31, 2020
* Migration to CRDs This is a nearly buildable update of the vSphere provider to CRD. The next commit should be a clean dep ensure to populate the vendors. Once that is complete, this repo should be buildable. The update was done using kubebuilder on a separate project and then introducing those CRD updates to this repo. The provider code was updated to work with the new structure. The kustomize and clusterctl yaml config files still needs updating before this can be tested. * Updated code, scripts, makefile for CRD migration Fixed the project post CRD migration. The build now works. There are a few changes in this commit, listed below. 1. Removed all unused code, scripts, and files. This includes the old controller's Dockerfile and makefile. 2. The old controller's Dockerfile and makefile have been rolled up into the top level. 3. Updated the container image name with our current registry store on GCR. 4. Made a number of changes to the CRD files under config/. 5. Modify how generate-yaml.sh works. It now calls kustomize instead of using sed. 6. Added a 'create-yaml' target in the makefile to generate the actual set of yaml files for clusterctl. Fixes kubernetes-sigs#38 and kubernetes-sigs#66 * Dep ensure to get latest vendor code * Fix makefile targets and CRD rbac files 1. Cleaned up makefile. Added 3 images, production, dev, and ci. 2. Modified the CI push target to decode the service account info from Travis CI. 3. Fix up the CRD rbac files that got lost in the squashes. 4. Updated the travis CI config Resolves kubernetes-sigs#79 * Fixed informers, comments, logs Fixed informers starting up. Removed commented out code and unused code. Added more logging. * Add scripts for testing in CI Added some scripts from the cluster-api-provider-gcp project that adds kubebuilder and other necessary components in CI for testing.
killianmuldoon
added
the
area/provider/vmware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From @rsdcastro on April 14, 2018 1:46
VM images provided by users might have the container runtime. This issue tracks verifying if the container runtime is already pre-installed and matches the version specified by the user.
Copied from original issue: kubernetes-retired/kube-deploy#687
The text was updated successfully, but these errors were encountered: