Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate quickstart ownerReference tests #7961

Closed
killianmuldoon opened this issue Jan 20, 2023 · 9 comments
Closed

Consolidate quickstart ownerReference tests #7961

killianmuldoon opened this issue Jan 20, 2023 · 9 comments
Assignees
Labels
area/testing Issues or PRs related to testing kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@killianmuldoon
Copy link
Contributor

#7575 adds two tests for ownerReference resilience. These tests, once they're stable, should be added to the ordinary quickstart and ClusterClass quickstart tests as an additional assertion in order to reduce the overall number of tests running.

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 20, 2023
@killianmuldoon
Copy link
Contributor Author

/assign

@killianmuldoon
Copy link
Contributor Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 20, 2023
@sbueringer sbueringer added the area/testing Issues or PRs related to testing label Jan 20, 2023
@fabriziopandini
Copy link
Member

fabriziopandini commented Jan 20, 2023

If we want to merge this with another test, let's consider using some other tests for this scope because IMO we should keep the quick start test as fast as possible because we run them on every PR.

Side note, I was thinking about the overall number of tests we are running from a different angle, and starting to consider if/how to split our E2E full job in two jobs, might be one for cluster classes and one not...

Another option, we can consider hopefully soon is to run some tests with the kubemark provider, so those tests are faster/less resource-hungry (prow machines are not really big...).

@sbueringer
Copy link
Member

If I saw correctly the tests with ownerref validation are still very fast (~ 2 m when they are run as part of e2e-full, https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/7606/pull-cluster-api-e2e-full-main/1616453975815491584)

@killianmuldoon
Copy link
Contributor Author

Yeah - it's very quick, but I agree that we might be able to take the opportunity to de-deupe a number of tests at the same time.

@killianmuldoon
Copy link
Contributor Author

Just to follow up on this. This test has been 100 percent green since being introduced on main (and green since an implementation issue was fixed for the minK8s run).

Time-wise this test has a similar runtime and variance to the quick-start tests. I think logically it will make those tests longer, but practically the difference is in the magnitude of seconds, and is dwarfed by the normal variance in the Cluster creation workflow.

Definitely think we should leave the tests to run for another week or two for a stronger signal of flakiness, but I don't think runtime should be a deciding factor in whether or not to include it as part of the PR Blocking / Informing tests.

@sbueringer
Copy link
Member

Sounds fine to me!

@sbueringer
Copy link
Member

Done in #8264

/close

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closing this issue.

In response to this:

Done in #8264

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants