-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate quickstart ownerReference tests #7961
Comments
/assign |
/triage accepted |
If we want to merge this with another test, let's consider using some other tests for this scope because IMO we should keep the quick start test as fast as possible because we run them on every PR. Side note, I was thinking about the overall number of tests we are running from a different angle, and starting to consider if/how to split our E2E full job in two jobs, might be one for cluster classes and one not... Another option, we can consider hopefully soon is to run some tests with the kubemark provider, so those tests are faster/less resource-hungry (prow machines are not really big...). |
If I saw correctly the tests with ownerref validation are still very fast (~ 2 m when they are run as part of e2e-full, https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/7606/pull-cluster-api-e2e-full-main/1616453975815491584) |
Yeah - it's very quick, but I agree that we might be able to take the opportunity to de-deupe a number of tests at the same time. |
Just to follow up on this. This test has been 100 percent green since being introduced on main (and green since an implementation issue was fixed for the minK8s run). Time-wise this test has a similar runtime and variance to the quick-start tests. I think logically it will make those tests longer, but practically the difference is in the magnitude of seconds, and is dwarfed by the normal variance in the Cluster creation workflow. Definitely think we should leave the tests to run for another week or two for a stronger signal of flakiness, but I don't think runtime should be a deciding factor in whether or not to include it as part of the PR Blocking / Informing tests. |
Sounds fine to me! |
Done in #8264 /close |
@sbueringer: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
#7575 adds two tests for ownerReference resilience. These tests, once they're stable, should be added to the ordinary quickstart and ClusterClass quickstart tests as an additional assertion in order to reduce the overall number of tests running.
/kind feature
The text was updated successfully, but these errors were encountered: