Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken book links #8160

Closed
sbueringer opened this issue Feb 23, 2023 · 12 comments · Fixed by #8162
Closed

Broken book links #8160

sbueringer opened this issue Feb 23, 2023 · 12 comments · Fixed by #8162
Assignees
Labels
kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sbueringer
Copy link
Member

Looks like we now have a few broken links in our book:

ERROR: 3 dead links found!
[✖] https://kubernetes.io/docs/admin/kube-apiserver/ → Status: 404
[✖] https://kubernetes.io/docs/admin/kube-controller-manager/ → Status: 404
[✖] https://kubernetes.io/docs/admin/kube-scheduler/ → Status: 404

https://github.com/sbueringer/cluster-api/actions/runs/4252572105/jobs/7396332975

/kind documentation
[One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels]

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 23, 2023
@sbueringer
Copy link
Member Author

cc @oscr @elmiko

@oscr
Copy link
Contributor

oscr commented Feb 23, 2023

@sbueringer I think this looks like a good first issue?

Change docs/admin/ -> docs/reference/command-line-tools-reference and the links work

@sbueringer
Copy link
Member Author

sbueringer commented Feb 23, 2023

Regarding the change yes, regarding time I'm not sure.

We probably need a quick fix because otherwise all PRs which touch markdown are blocked

(help wanted issues are usually not time-sensitive)

@oscr
Copy link
Contributor

oscr commented Feb 23, 2023

Then I or someone in comms will fix it during the evening.

@elmiko
Copy link
Contributor

elmiko commented Feb 23, 2023

i could take a look today

@elmiko
Copy link
Contributor

elmiko commented Feb 23, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 23, 2023
@elmiko
Copy link
Contributor

elmiko commented Feb 23, 2023

/assign elmiko

@oscr
Copy link
Contributor

oscr commented Feb 23, 2023

@elmiko Awesome! Feel free to ping me when you have a pr to get a quick review

@elmiko
Copy link
Contributor

elmiko commented Feb 23, 2023

i think @damdo will end up making the patch, but we'll get something up today

@elmiko
Copy link
Contributor

elmiko commented Feb 23, 2023

/assign damdo

@k8s-ci-robot
Copy link
Contributor

@elmiko: GitHub didn't allow me to assign the following users: damdo.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damdo
Copy link
Member

damdo commented Feb 23, 2023

Hey yes, here is the patch: #8162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants