Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCE machine actuator should collect current state #99

Closed
rsdcastro opened this issue Apr 17, 2018 · 5 comments
Closed

GCE machine actuator should collect current state #99

rsdcastro opened this issue Apr 17, 2018 · 5 comments
Assignees

Comments

@rsdcastro
Copy link

From @jessicaochen on January 11, 2018 17:8

The machine actuator should get current state from the actual sources (eg. kubelet version from machine, VM info from gce) instead of a cached last-applied state. This will help with cases like the state changing under the covers.

https://github.com/kubernetes/kube-deploy/blob/master/cluster-api-gcp/cloud/google/instancestatus.go#L13

Copied from original issue: kubernetes-retired/kube-deploy#482

@rsdcastro
Copy link
Author

From @karan on January 24, 2018 21:41

I'll start working on this, and handle updates to spec.providerConfig first. Specifically, zone, machineType, and image.

@rsdcastro rsdcastro added this to the cluster-api-alpha-implementation milestone Apr 17, 2018
@karan
Copy link
Contributor

karan commented May 29, 2018

/assign @mkjelland

since she's working on the gce provider now.

@karan
Copy link
Contributor

karan commented May 29, 2018

/unassign @karan

@mkjelland
Copy link
Contributor

/assign @mkjelland

@roberthbailey
Copy link
Contributor

This issue was moved to kubernetes-sigs/cluster-api-provider-gcp#20

chuckha pushed a commit to chuckha/cluster-api that referenced this issue Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants