Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Rename "others..." tab with "Other providers..." #10031

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

SD-13
Copy link
Contributor

@SD-13 SD-13 commented Jan 22, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9953
This PR renames the instances of "others..." tab to "Other providers..." in the quickstart guide.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Jan 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2024
@SD-13
Copy link
Contributor Author

SD-13 commented Jan 22, 2024

cc @fabriziopandini @sbueringer

@SD-13
Copy link
Contributor Author

SD-13 commented Jan 22, 2024

@sbueringer Added your suggested changes!

@sbueringer
Copy link
Member

Thank you!

Btw. Netlify also hosts a version of this branch

image

Pages changed > user/quick-start.html - view

@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6d4b2fd892f9606def0c4886041c956828be4742

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@SD-13
Copy link
Contributor Author

SD-13 commented Jan 22, 2024

Thank you!

Btw. Netlify also hosts a version of this branch
image

Pages changed > user/quick-start.html - view

Ahh, didn't notice. Thanks for letting me know :)

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area documentation

/lgtm

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation and removed do-not-merge/needs-area PR is missing an area label labels Jan 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit cba8471 into kubernetes-sigs:main Jan 22, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Jan 22, 2024
@SD-13 SD-13 deleted the rename_others_tab branch January 22, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Others tabs in the Quick-Start
4 participants