Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱Changelog entry to include cert-manager to v1.14.2 #10188

Conversation

troy0820
Copy link
Member

What this PR does / why we need it:

  • Updates the changelog to include cert-manager to v1.14.2 for v1.6.2 and v1.5.6

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 21, 2024
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7f420faddc0de4189ee7b0c32f78a53bfccfa4d6

@chrischdi
Copy link
Member

/approve

I'll also edit the GH release notes.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2024
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve cancel

/hold cancel

Let's preserve the old PR ID

@@ -14,11 +14,11 @@
- ClusterCacheTracker: Fix ClusterCacheTracker memory leak (#10065)

## :seedling: Others
- clusterctl: Bump cert-manager to v1.14.1 (#10121)
- clusterctl: Bump cert-manager to v1.14.2 (#10128)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- clusterctl: Bump cert-manager to v1.14.2 (#10128)
- clusterctl: Bump cert-manager to v1.14.2 (#10121) (#10128)

@@ -20,15 +20,15 @@
- Machine: Watch external objects for machine before deleting (#10177)

## :seedling: Others
- clusterctl: Bump cert-manager to v1.14.1 (#10120)
- clusterctl: Bump cert-manager to v1.14.2 (#10127)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- clusterctl: Bump cert-manager to v1.14.2 (#10127)
- clusterctl: Bump cert-manager to v1.14.2 (#10120) (#10127)

@k8s-ci-robot k8s-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 22, 2024
@chrischdi
Copy link
Member

One nit.

Already updated the release notes.

Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
@troy0820 troy0820 force-pushed the troy0820/fix-release-notes-in-changelog branch from 7f7c5d8 to 4198f75 Compare February 22, 2024 14:14
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2024
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
@cahillsf
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 32224da0253fa434f4cb56f01f73288f40fb1837

@k8s-ci-robot k8s-ci-robot merged commit 0f47a19 into kubernetes-sigs:main Feb 23, 2024
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants