🌱 clusterctl: Add 0 default to worker-machine-count help #10203
Conversation
Cobra nicely adds the default value for arguments, except in the case where the default is 0 or empty. This causes the help output for `clusterctl generate cluster` `--worker-machine-count` to not include its default of 0, unlike `--control-plane-machine-count` that has a default of 1. This change explicitly adds the default value to the help text for `--worker-machine-count` to make it easier to discover what to expect when running the command without this argument. Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
k8s-ci-robot
added
area/clusterctl
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
the
approved
There was a problem hiding this comment.
@stmcginnis thank you for picking up this issue!
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e192f3670f1d22a1642849df427139ddadd1c54f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.6 |
|
@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@fabriziopandini: new pull request created: #10205 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Cobra nicely adds the default value for arguments, except in the case where the default is 0 or empty. This causes the help output for
clusterctl generate cluster--worker-machine-countto not include its default of 0, unlike--control-plane-machine-countthat has a default of 1.This change explicitly adds the default value to the help text for
--worker-machine-countto make it easier to discover what to expect when running the command without this argument.Help text after this change:
Which issue(s) this PR fixes:
Fixes #10173
/area clusterctl