Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 📖 Add extra information in the supported labels and annotations tables #10425

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hackeramitkumar
Copy link
Member

What this PR does / why we need it:
I have sorted all of the labels and annotations in alphabatical order. And also added 2 new columns in the table, one for Manage By and other for the Applies to.

Which issue(s) this PR fixes
Fixes #7441

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 11, 2024
@hackeramitkumar hackeramitkumar changed the title 📖 Add extra information in the supported labels and annotations tables [WIP] 📖 Add extra information in the supported labels and annotations tables Apr 13, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2024
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hackeramitkumar sorry if I lost track of this PR in my notification backlog 😅

This is an outstanding research work, it adds a lot of value to this page.
I made a first pass on annotations.
I will try to get back to labels ASAP

docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
docs/book/src/reference/labels_and_annotations.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2024
Signed-off-by: hackeramitkumar <amit9116260192@gmail.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2024
@hackeramitkumar
Copy link
Member Author

Hi @fabriziopandini ,

Thanks for reviewing the annotations and providing suggestions. I have resolved all the comments and made the suggested changes to the annotations. Could you please review the labels as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add extra information in the supported labels and annotations tables
3 participants