Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃殌 Release v1.7.3 #10744

Merged
merged 1 commit into from
Jun 11, 2024
Merged

馃殌 Release v1.7.3 #10744

merged 1 commit into from
Jun 11, 2024

Conversation

vishalanarase
Copy link
Member

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 10, 2024
@adilGhaffarDev
Copy link
Contributor

/hold
LGTM from my side. Holding so others can also review.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2024
adilGhaffarDev
adilGhaffarDev approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@adilGhaffarDev adilGhaffarDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2024
sbueringer
sbueringer reviewed Jun 11, 2024
View reviewed changes
CHANGELOG/v1.7.3.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2024
@vishalanarase
馃殌 Release v1.7.3
a302fa1 
Signed-off-by: Vishal Anarase <iamvishalanarase@gmail.com>
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 522c6158c011f61cfbc609ef597eb76bfef465a5

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adilGhaffarDev, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c236e8c into kubernetes-sigs:main Jun 11, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Jun 11, 2024
@ader1990
Copy link
Contributor

@vishalanarase Can you please check #10749?
Maybe some github actions were not run yet?

Thanks.

@adilGhaffarDev
Copy link
Contributor

@vishalanarase Can you please check #10749? Maybe some github actions were not run yet?

Thanks.

release is not published yet, only tag is created.

@ader1990
Copy link
Contributor

@vishalanarase Can you please check #10749? Maybe some github actions were not run yet?
Thanks.

release is not published yet, only tag is created.

because of the release being created by creating the tag, see https://github.com/kubernetes-sigs/cluster-api/releases/tag/v1.7.3, clusterctl init started failing because it cannot find the release 1.7.3 "core-components.yaml" and using the clusterctl init --core cluster-api:v1.7.2 still fails, as it still tries to find the bootstrap yaml for 1.7.3

@ader1990
Copy link
Contributor

ader1990 commented Jun 11, 2024 •
edited
Loading

As the name of this merged PR suggests, I assumed that the release should have been created, the naming is really confusing.

@chrischdi
Copy link
Member

Let's please not mix up discussions and continue in #10749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@adilGhaffarDev adilGhaffarDev adilGhaffarDev approved these changes

@hackeramitkumar hackeramitkumar Awaiting requested review from hackeramitkumar

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vishalanarase @adilGhaffarDev @sbueringer @k8s-ci-robot @ader1990 @chrischdi