Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Remove vendor and Bazel #1321

Merged
merged 3 commits into from Aug 28, 2019
Merged

✨Remove vendor and Bazel #1321

merged 3 commits into from Aug 28, 2019

Conversation

vincepri
Copy link
Member

What this PR does / why we need it:
This PR removes the vendor folder and adapts Makefile and Dockerfile.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2019
@vincepri vincepri force-pushed the remove-vendor branch 2 times, most recently from cd04ecc to 68b46e2 Compare August 26, 2019 15:14
@vincepri
Copy link
Member Author

/test pull-cluster-api-test

@vincepri
Copy link
Member Author

/hold

Holding until other PRs have merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2019
@vincepri vincepri force-pushed the remove-vendor branch 2 times, most recently from 8deee21 to 2590e1b Compare August 26, 2019 15:35
ncdc
ncdc reviewed Aug 26, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
ncdc
ncdc reviewed Aug 26, 2019
View reviewed changes
hack/tools/go.mod Outdated Show resolved Hide resolved
@vincepri vincepri changed the title ✨ Remove vendor ✨Remove vendor Aug 26, 2019
@vincepri
Copy link
Member Author

@ncdc This should be ready

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2019
@ncdc
Copy link
Contributor

ncdc commented Aug 26, 2019

/retest

ncdc
ncdc reviewed Aug 26, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@vincepri
Copy link
Member Author

@ncdc fixed and matched CABPK

@ncdc
Copy link
Contributor

ncdc commented Aug 26, 2019

LGTM. Would like @detiber to 👀 too

@vincepri
Remove vendor folder
3c725c4 
Signed-off-by: Vince Prignano <vincepri@vmware.com>
@vincepri vincepri force-pushed the remove-vendor branch 2 times, most recently from fc29c26 to c25d626 Compare August 26, 2019 23:16
@vincepri
✨ Update scripts, Dockerfile and Makefile for vendor removal
0897c71 
Signed-off-by: Vince Prignano <vincepri@vmware.com>
@vincepri
Copy link
Member Author

/test pull-cluster-api-test

@vincepri vincepri changed the title ✨Remove vendor ✨Remove vendor and Bazel Aug 27, 2019
@vincepri vincepri force-pushed the remove-vendor branch 2 times, most recently from 2574f9f to 8369f72 Compare August 27, 2019 15:09
@vincepri
Copy link
Member Author

/retest

detiber
detiber reviewed Aug 27, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
scripts/ci-is-vendor-in-sync.sh Outdated Show resolved Hide resolved
@vincepri vincepri force-pushed the remove-vendor branch 2 times, most recently from 5858007 to 8ff6442 Compare August 27, 2019 16:13
@vincepri
✨ Remove Bazel
4e77f90 
Signed-off-by: Vince Prignano <vincepri@vmware.com>
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 27, 2019 •
edited

@vincepri: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-cluster-api-vendor-in-sync 4e77f90 link /test pull-cluster-api-vendor-in-sync

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vincepri
Copy link
Member Author

/test pull-cluster-api-test

@detiber
Copy link
Member

detiber commented Aug 28, 2019

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 80572d3 into kubernetes-sigs:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc ncdc left review comments

@detiber detiber detiber left review comments

Assignees

@detiber detiber

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vincepri @k8s-ci-robot @ncdc @detiber