Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clusterctl/kind: return stdout and not combined output #1792

Conversation

@neolit123
Copy link
Contributor

neolit123 commented Nov 21, 2019

What this PR does / why we need it:

Ideally only the stdout of kind commands should be captured
and returned, in case kind commands also contain stderr.

Fixes a recent bug where the kind command "get kubeconfig-path"
started printing a deprecation message to stderr.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

NONE?

/kind bug
/priority important-longterm

@k8s-ci-robot k8s-ci-robot requested review from justinsb and ncdc Nov 21, 2019
@k8s-ci-robot k8s-ci-robot added the size/S label Nov 21, 2019
@vincepri vincepri changed the base branch from master to release-0.2 Nov 21, 2019
@vincepri vincepri changed the base branch from release-0.2 to master Nov 21, 2019
@neolit123 neolit123 changed the base branch from master to release-0.2 Nov 21, 2019
@k8s-ci-robot k8s-ci-robot added size/XXL and removed size/S labels Nov 21, 2019
@neolit123 neolit123 force-pushed the neolit123:clusterctl-kind-output-fix branch from 1f60998 to 910389a Nov 21, 2019
@k8s-ci-robot k8s-ci-robot added size/S and removed size/XXL labels Nov 21, 2019
@neolit123 neolit123 force-pushed the neolit123:clusterctl-kind-output-fix branch from 910389a to c231b33 Nov 21, 2019
@neolit123

This comment has been minimized.

Copy link
Contributor Author

neolit123 commented Nov 21, 2019

https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/1792/pull-cluster-api-verify/1197602407840747523

make[2]: Leaving directory '/home/prow/go/src/sigs.k8s.io/cluster-api'
make[1]: Leaving directory '/home/prow/go/src/sigs.k8s.io/cluster-api'
!!! Generated code is out of date:
 M go.mod

Please run make generate.
make: *** [Makefile:288: verify] Error 1

yet, make generate (or make generate-go) does not generate changes.

@vincepri

This comment has been minimized.

Copy link
Member

vincepri commented Nov 22, 2019

@neolit123 Are you using Go 1.12 or 1.13?

@neolit123

This comment has been minimized.

Copy link
Contributor Author

neolit123 commented Nov 22, 2019

@vincepri go 1.13.4

@vincepri

This comment has been minimized.

Copy link
Member

vincepri commented Nov 22, 2019

We’re still on Go 1.12, the linter is failing because go.mod generates different results when using a version vs the other, if you can switch and regenerate the CI should go green

Ideally only the stdout of kind commands should be captured
and returned, in case kind commands also contain stderr.

Fixes a recent bug where the kind command "get kubeconfig-path"
started printing a deprecation message on stderr.
@neolit123 neolit123 force-pushed the neolit123:clusterctl-kind-output-fix branch from c231b33 to 8618237 Nov 27, 2019
@neolit123

This comment has been minimized.

Copy link
Contributor Author

neolit123 commented Nov 27, 2019

@vincepri vincepri added this to the v0.2.x milestone Dec 2, 2019
Copy link
Member

vincepri left a comment

/lgtm

@detiber

This comment has been minimized.

Copy link
Member

detiber commented Dec 2, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 81cb545 into kubernetes-sigs:release-0.2 Dec 2, 2019
12 checks passed
12 checks passed
Header rules No header rules processed
Details
Pages changed 5 new files uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 3 redirect rules processed
Details
cla/linuxfoundation neolit123 authorized
Details
deploy/netlify Deploy preview ready!
Details
pull-cluster-api-build Job succeeded.
Details
pull-cluster-api-integration Job succeeded.
Details
pull-cluster-api-make Job succeeded.
Details
pull-cluster-api-test Job succeeded.
Details
pull-cluster-api-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.