Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clusterctl/kind: return stdout and not combined output #1792

Merged
merged 1 commit into from Dec 2, 2019
Merged

clusterctl/kind: return stdout and not combined output #1792

merged 1 commit into from Dec 2, 2019

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Nov 21, 2019 •
edited

What this PR does / why we need it:

Ideally only the stdout of kind commands should be captured
and returned, in case kind commands also contain stderr.

Fixes a recent bug where the kind command "get kubeconfig-path"
started printing a deprecation message to stderr.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

NONE?

/kind bug
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 21, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 21, 2019
@vincepri vincepri changed the base branch from master to release-0.2 November 21, 2019 19:41
@vincepri vincepri changed the base branch from release-0.2 to master November 21, 2019 19:41
@neolit123 neolit123 changed the base branch from master to release-0.2 November 21, 2019 19:42
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 21, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 21, 2019
@neolit123
Copy link
Member Author

neolit123 commented Nov 21, 2019 •
edited

https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/1792/pull-cluster-api-verify/1197602407840747523

make[2]: Leaving directory '/home/prow/go/src/sigs.k8s.io/cluster-api'
make[1]: Leaving directory '/home/prow/go/src/sigs.k8s.io/cluster-api'
!!! Generated code is out of date:
 M go.mod

Please run make generate.
make: *** [Makefile:288: verify] Error 1

yet, make generate (or make generate-go) does not generate changes.

@vincepri
Copy link
Member

@neolit123 Are you using Go 1.12 or 1.13?

@neolit123
Copy link
Member Author

neolit123 commented Nov 22, 2019 •
edited

@vincepri go 1.13.4

@vincepri
Copy link
Member

We’re still on Go 1.12, the linter is failing because go.mod generates different results when using a version vs the other, if you can switch and regenerate the CI should go green

@neolit123
clusterctl/kind: return stdout and not combined output
8618237 
Ideally only the stdout of kind commands should be captured
and returned, in case kind commands also contain stderr.

Fixes a recent bug where the kind command "get kubeconfig-path"
started printing a deprecation message on stderr.
@neolit123
Copy link
Member Author

@vincepri updated.
although something weird is going on with github.

this force-push
https://github.com/kubernetes-sigs/cluster-api/compare/c231b331ae02262b555b64438cd95bf4e8b11bcf..86182375777a2a68f1a343c8d60d87d7366c667c

made a change to gomod

but it's not reflected here:
https://github.com/kubernetes-sigs/cluster-api/pull/1792/files

@vincepri vincepri added this to the v0.2.x milestone Dec 2, 2019
vincepri
vincepri approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2019
@detiber
Copy link
Member

detiber commented Dec 2, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit 81cb545 into kubernetes-sigs:release-0.2 Dec 2, 2019
@ncdc ncdc mentioned this pull request Dec 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@justinsb justinsb Awaiting requested review from justinsb

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.2.x
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@neolit123 @vincepri @detiber @k8s-ci-robot