馃尡 [e2e] add debug output for deployment failures #3468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Merged
3 tasks
|
/assign @CecileRobertMichon |
vincepri
approved these changes
Aug 7, 2020
There was a problem hiding this comment.
/approve
/assign @fabriziopandini @sedefsavas
/milestone v0.3.9
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thanks @mboersma |
mboersma
force-pushed
the
e2e-failure-help
branch
from
32af37a
to
2793d9d
Compare
k8s-ci-robot
added
size/M
mboersma
force-pushed
the
e2e-failure-help
branch
from
2793d9d
to
9455243
Compare
k8s-ci-robot
added
size/S
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Pretty-prints the JSON representation of a deployment when
WaitForDeploymentsAvailablefails an e2e test.We use these framework methods downstream in CAPZ and could use more context when debugging e2e failures. I'd like to follow on by also printing relevant Kubernetes events in
DescribeFailedDeployment, but wanted to keep this simple.Which issue(s) this PR fixes:
N/A, but see kubernetes-sigs/cluster-api-provider-azure#807