Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 e2e: Resolve flake: Wait for controlplane to be available on management cluster #3650

Merged

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Sep 16, 2020

What this PR does / why we need it:
This PR fixes a flake on kcp-adoption e2e test due to the code querying for object aggressively after apply

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 16, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 16, 2020
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-full
/area testing
/milestone v0.3.10

@k8s-ci-robot k8s-ci-robot added this to the v0.3.10 milestone Sep 16, 2020
@k8s-ci-robot k8s-ci-robot added the area/testing Issues or PRs related to testing label Sep 16, 2020
@benmoss
Copy link

benmoss commented Sep 16, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2020
@vincepri
Copy link
Member

@fabriziopandini Can we adjust the title to include what the fix is?

@randomvariable
Copy link
Member

/retitle 馃尡 e2e: Resolve flake: Wait for controlplane to be available on management cluster

@k8s-ci-robot k8s-ci-robot changed the title 馃尡 Fix kcp-adoption e2e flakes 馃尡 e2e: Resolve flake: Wait for controlplane to be available on management cluster Sep 16, 2020
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benmoss, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit f96d5f0 into kubernetes-sigs:master Sep 16, 2020
@fabriziopandini fabriziopandini deleted the fix-kcp-adoption-flakes branch September 17, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants