⚠️ Move envtest setup under internal/envtest

[vincepri]

What this PR does / why we need it:

This change refactors all envtest suites to use the internal/envtest
package instead of test/helpers. These helpers aren't useful to folks
outside of Cluster API because of the nature how we setup the CRDs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #4687

[sedefsavas]

In CAPA, we are using CleanUp(), CreateNamespace() from that package:
https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/2a183f580873ed46aebdbba77da212a3476682aa/exp/api/v1alpha3/webhook_test.go#L64

helpers.TestEnvironment is part of our TestEnvironment:
https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/2a183f580873ed46aebdbba77da212a3476682aa/test/helpers/envtest.go#L95

[vincepri]

Do you overwrite the CRDs?

[sedefsavas]

Do you mean adding to scheme several times? If so, yes

[vincepri]

I meant more about how you're using this envtest, given that it mostly initializes Cluster API-related things. For example the webhooks registered expect the Cluster API CRDs, and internally it's using relative paths (to the CAPI repository) to determine how to install CRDs. To be fair, the Create/Cleanup functions should go somewhere else and this package should use them, rather than trying to expose and use it directly

[sedefsavas]

We don't use the initialization logic, just adding TestEnvironment struct into our TestEnvironment and handle its initialization. Just to use helper functions like CleanUp, I don't think CleanUp has specific assumptions. It is a small method we can copy what we need.

[CecileRobertMichon]

We don't use any of these in CAPZ. Overall lgtm.

[k8s-ci-robot]

@vincepri: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-cluster-api-apidiff-main	aa049f1	link	/test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[CecileRobertMichon]

/lgtm

[vincepri]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment