Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 fix panic in clusterctl backup #5050

Merged
merged 1 commit into from Aug 4, 2021
Merged

馃悰 fix panic in clusterctl backup #5050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/clusterctl/client/cluster/mover.go
View file
Open in desktop
Expand Up @@ -366,7 +366,7 @@ func (o *objectMover) backup(graph *objectGraph, directory string) error {
moveSequence := getMoveSequence(graph)

// Save all objects group by group
log.Info("Saving files to %s", directory)
log.Info(fmt.Sprintf("Saving files to %s", directory))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this logger not have Infof?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference, let's make sure that PR titles have more explicit information, like Fix panic in logger not using string interpolation ....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup will do. The logger has no Infof func (it's the go-logr/logr.Logger interface)

for groupIndex := 0; groupIndex < len(moveSequence.groups); groupIndex++ {
if err := o.backupGroup(moveSequence.getGroup(groupIndex), directory); err != nil {
return err
Expand Down