🌱 Operator two small required changes

[asalkeld]

What this PR does / why we need it:

When implementing the capi operator (#4926) that uses
clusterctl as a library there were some required changes needed to complete the PR.

• Add a public factory for githubRepository
  This is needed because it is normally created in the same package, but since the operator is outside, we can't use this function.
• Add a way to customize the component objects
  The operator API defines a different way of customizing the provider's components (to how clusterctl does it natively) so we need a way of injecting these changes back into the Component. This commit just adds a SetObjs() function.

[k8s-ci-robot]

Hi @asalkeld. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fabriziopandini]

@asalkeld I'm not sure I fully understand the rational for this changes; some of the feedback are more request of clarifications than real suggestions..

[enxebre]

hey @asalkeld could you include in the PR desc and commit desc context about the "Why" in addition to the "what" (i.e git ci -m"imperative mood action" -m"WHY") so there's a lower entry barrier for reviewers not that familiar with clusterctl? Thanks!

/ok-to-test

[fabriziopandini]

Q: Can we avoid this wrapper and just make the existing constructor public?

[asalkeld]

Sure I can make it public and return the private struct.
I made the new constructor to return the Repository interface rather than the private type, since the unit tests use private
functions we still needed that. 🤷‍♂️ - not much difference I guess

[asalkeld]

Just tried this and I get this lint error

cmd/clusterctl/client/repository/repository_github.go:120:137: unexported-return: exported func NewGitHubRepository returns unexported type *repository.gitHubRepository, which can be annoying to use (revive)
func NewGitHubRepository(providerConfig config.Provider, configVariablesClient config.VariablesClient, opts ...githubRepositoryOption) (*gitHubRepository, error) {

[asalkeld]

so there were not many uses of the private struct, so i have changed the return to "Repository" and cast the usages in the unit tests..

[asalkeld]

/retest

[fabriziopandini]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment