-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃摉 book: upgrade for v1.0 and v1beta1 #5400
馃摉 book: upgrade for v1.0 and v1beta1 #5400
Conversation
I'll do another round of review to check if I forgot something |
7439b6d
to
66722e7
Compare
Hope I got everything now. |
@@ -20,10 +20,6 @@ with a valid lifespan of a year, and will be automatically regenerated when the | |||
|
|||
See the section on [upgrading clusters][upgrades]. | |||
|
|||
#### Using Kubeadm Control Plane when upgrading from Cluster API v1alpha2 (0.2.x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume it's good enough that we cover this in the two older books, but if there are concerns it's absolutely fine for me to add it again.
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
should we hold this until the release is out? I believe book is currently getting published from the main branch
Agree. I think we should merge after the GitHub release exists so that the clusterctl links in the quickstart are rendered correctly /hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like everything is covered. No typos or anything like that that I could find.
/lgtm
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
66722e7
to
04782ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #