🌱 Topology controller upgrades templates in place when there are only metadata changes #5416
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
fabriziopandini
requested review from
vincepri
and removed request for
enxebre and
JoelSpeed
k8s-ci-robot
added
the
size/L
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
Looks good, very nice optimization only one comment regarding an additional test case |
| // If there are no changes in the spec, and thus only changes in metadata, instead of doing a full template | ||
| // rotation we patch the object in place. This avoids recreating machines. | ||
| if !patchHelper.HasSpecChanges() { | ||
| log.Infof("Patching %s", tlog.KObj{Obj: in.desired}) |
There was a problem hiding this comment.
should this be log.V(3) consistently with above?
There was a problem hiding this comment.
All the actual changes are logged at v0, like in this cases, while at v3 we are adding tracing info e.g. surfacing that when we detected no changes.
|
@sbueringer @enxebre comment addressed PTAL |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
fabriziopandini
force-pushed
the
topology-should-upgrade-template-inplace-when-possible
branch
from
eef2cf0
to
f185d8c
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
fabriziopandini
deleted the
topology-should-upgrade-template-inplace-when-possible
branch
What this PR does / why we need it:
This PR makes the topology controller to upgrade templates in place when there are only metadata changes (instead of doing a template rotation, which in turns triggers a machine rollout)
Which issue(s) this PR fixes:
Fixes #5413