Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 use k8s-staging-test-infra/gcb-docker-gcloud #5474

Merged

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Oct 22, 2021

Related:

Use a version of gcb-docker-cloud that is hosted in a
community-owned repo instead of a google.com-owned repo

Signed-off-by: Arnaud Meukam ameukam@gmail.com

Related:
  - Part of: kubernetes/k8s.io#1523
  - Followup to: kubernetes/test-infra#23656

Use a version of gcb-docker-cloud that is hosted in a
community-owned repo instead of a google.com-owned repo

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 22, 2021
@ameukam ameukam changed the title use k8s-staging-test-infra/gcb-docker-gcloud 馃尡 use k8s-staging-test-infra/gcb-docker-gcloud Oct 22, 2021
@ameukam
Copy link
Member Author

ameukam commented Oct 22, 2021

cc @CecileRobertMichon @vincepri

@sbueringer
Copy link
Member

sbueringer commented Oct 22, 2021

@ameukam Thx!

In general lgtm. I'm not sure where we should mention the change. As we're already on v1beta1 it might be good enough to add it to the v1alpha4=>v1beta1 guide. An alternative would be to start an v1.0=>v1.1 guide (doesn't necessarily have to be in this PR, and I can take that over, if that's preferred)

Let's see what others think

@fabriziopandini
Copy link
Member

fabriziopandini commented Oct 22, 2021

+1 to document this in a new migration doc in another PR/low priority (I assume this change is happening in all the repos, so we should be fine no matter)
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2021
@sbueringer
Copy link
Member

+1 to document this in a new migration doc in another PR/low priority (I assume this change is happening in all the repos, so we should be fine no matter) /lgtm

Good point. I think if the same PR is opened in all CAPI repos it's fine to not document it as it's already fixed everywhere.

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit 610e290 into kubernetes-sigs:main Oct 22, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants