✨ add ClusterClassReconciler #5486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/area topology |
|
/retest |
1 similar comment
|
/retest |
ykakarap
force-pushed
the
clusterclass-controller
branch
3 times, most recently
from
c4e5586
to
3c29472
Compare
|
/retest |
|
/test pull-cluster-api-test-main |
|
/assign @fabriziopandini @sbueringer |
sbueringer
reviewed
Oct 25, 2021
vincepri
reviewed
Oct 25, 2021
ykakarap
force-pushed
the
clusterclass-controller
branch
from
3c29472
to
7b0fe07
Compare
enxebre
reviewed
Oct 26, 2021
ykakarap
force-pushed
the
clusterclass-controller
branch
from
7b0fe07
to
4094fe9
Compare
k8s-ci-robot
added
size/XL
sbueringer
reviewed
Oct 28, 2021
|
lgtm pending last round of nits |
ykakarap
force-pushed
the
clusterclass-controller
branch
from
4094fe9
to
cd175c3
Compare
|
Thx! |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a new ClusterClassReconciler. This reconciler adds the ClusterClass as an owner reference to all the templates referenced in the given ClusterClass.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #5446