馃尡 Set MachineDeployment selector in managed clusters #5492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As of today when we are creating MachineDeployments in managed cluster we are not setting spec.selector field, and thus it gets initialised by web hooks to something like
However, given that selector labels are enforced in spec.template.metadata where we are already adding topology specific labels, so we end up with
And the co-existance of both
cluster.x-k8s.io/deployment-name
andtopology.cluster.x-k8s.io/deployment-name
might be confusing at first sight (both at MD level and also on MS and Machines down the chain).This PR is proposing a change in how we generate the generated cluster so the resulting machine deployment object will be:
With a simpler and cleaner label set (both at MD level and also on MS and Machines down the chain).