馃尡 Promote enxebre to maintainer #5497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
+1 |
1 similar comment
|
+1 |
|
Thanks for your contribution so far! |
|
+1 |
2 similar comments
|
+1 |
|
+1 |
|
/lgtm |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR moves @enxebre from reviewers to maintainers. @enxebre has been involved with the project and helped it evolve since its early stage. He was involved in discussions about Aggregated API vs CRDs, bootstrapping decoupling, cluster vs machine management, composability, project gradual adoption, etc. that influenced the v1alpha3 redesign. He drove the design and led the team which contributed autoscaling support, Machine health checking, externally managed infrastructure support, and spot instances.
Proposals: https://github.com/kubernetes-sigs/cluster-api/search?q=enxebre
PRs: https://github.com/kubernetes-sigs/cluster-api/pulls?q=is%3Apr+is%3Aclosed+author%3Aenxebre
Reviews: https://github.com/kubernetes-sigs/cluster-api/pulls?page=1&q=is%3Apr+enxebre
Issues: https://github.com/kubernetes-sigs/cluster-api/issues?q=is%3Aissue+author%3Aenxebre+
/cc @fabriziopandini @vincepri
/hold for approvers and for lazy consensus until Monday 11/1.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #