Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Tilt fixups: Docs correction, Make label optional, infer manager name when not specified #5507

Merged
merged 3 commits into from
Oct 28, 2021
Merged

🌱 Tilt fixups: Docs correction, Make label optional, infer manager name when not specified #5507

merged 3 commits into from
Oct 28, 2021

Conversation

randomvariable
Copy link
Member

  • Tiltfile: Restore the use of labels being optional
  • docs: Correct location of Tilt debug options

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 27, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 27, 2021
@randomvariable randomvariable mentioned this pull request Oct 27, 2021
Closed
fabriziopandini
fabriziopandini reviewed Oct 27, 2021
View reviewed changes
docs/book/src/developer/tilt.md Outdated Show resolved Hide resolved
docs/book/src/developer/tilt.md Outdated Show resolved Hide resolved
Tiltfile Outdated Show resolved Hide resolved
Tiltfile Show resolved Hide resolved
@randomvariable
docs: Move Tiltfile debug outside of AWS tab
b35e309 
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@randomvariable
Tiltfile: Infer manager name from manifests, make labelling optional
d018fee 
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@randomvariable
Copy link
Member Author

@fabriziopandini made some changes, removed manager_name entirely

@sbueringer
Copy link
Member

/lgtm
nice cleanup

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2021
mboersma
mboersma approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I tested this locally and it fixes the CAPZ case (although we updated tilt-provider.json, so things are working regardless). I prefer this to #5505.

@randomvariable
Copy link
Member Author

Check Markdown links / Broken Links (pull_request)

Can't seem to find the error. Anyone can point me at the broken thing?

@sbueringer
Copy link
Member

sbueringer commented Oct 27, 2021 •
edited

Check Markdown links / Broken Links (pull_request)

Can't seem to find the error. Anyone can point me at the broken thing?

ERROR: 1 dead links found!
[✖] https://docs.cert-manager.io/en/latest/getting-started/install/kubernetes.html → Status: 403

Looks like the cert-manager website has certificate issues and returns errors.

@randomvariable
docs: Fix broken cert-manager link
a3325f7 
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2021
@randomvariable
Copy link
Member Author

Pushed a fix as a new commit.

@sbueringer
Copy link
Member

Ah they dropped the sub-domain
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2021
fabriziopandini
fabriziopandini reviewed Oct 28, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

docs/book/src/developer/tilt.md Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0a29dba into kubernetes-sigs:main Oct 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Oct 28, 2021
@randomvariable randomvariable deleted the tilt-fixups branch October 28, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@mboersma mboersma mboersma approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@randomvariable @sbueringer @k8s-ci-robot @mboersma @fabriziopandini