-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Promote randomvariable to KCP maintainer #5508
Merged
k8s-ci-robot
merged 1 commit into
kubernetes-sigs:main
from
randomvariable:controlplane-randomvariable-owner
Nov 4, 2021
Merged
🌱 Promote randomvariable to KCP maintainer #5508
k8s-ci-robot
merged 1 commit into
kubernetes-sigs:main
from
randomvariable:controlplane-randomvariable-owner
Nov 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
k8s-ci-robot
added
the
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
label
Oct 27, 2021
k8s-ci-robot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Oct 27, 2021
randomvariable
changed the title
Promote randomvariable to KCP maintainer
🌱 Promote randomvariable to KCP maintainer
Oct 27, 2021
+1 |
1 similar comment
+1 |
+1!! /lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Oct 27, 2021
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Oct 27, 2021
+1 |
1 similar comment
+1 |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Oct 27, 2021
/lgtm |
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Naadir Jeewa jeewan@vmware.com
What this PR does / why we need it:
This PR adds myself to cluster-api-controlplane-provider-kubeadm-maintainers.
I was one of the co-authors of the original spec for KCP (#1899), wrote the pod proxy that KCP uses to conduct healthchecks (#2030) across the board, and the initial etcd client taken to completion by @chuckha in #2237 .
I'm also working upstream in etcd (etcd-io/etcd#13340) to improve health check endpoints that we ultimately consume to improve reliability long term.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #