馃尡 clusterctl config cluster: render ClusterClass before Cluster #5515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
k8s-ci-robot
added
the
cncf-cla: yes
sbueringer
changed the title
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
What this PR does / why we need it:
clusterctl config clusterrenders a Cluster and a ClusterClass with all its referenced templates. This PR changes the order so that the ClusterClass is rendered before the Cluster. I think it makes sense to first deploy the ClusterClass and then the Cluster, as the Cluster is referencing the ClusterClass.xref: https://kubernetes.slack.com/archives/C8TSNPY4T/p1635342262173200
The plan is to introduce variable validation for Cluster variables later on. If we make it mandatory that a ClusterClass must exist when a Cluster with variables is created (so that we can validate the variables), this change is necessary.
But overall I think it's just a good idea to render them in this order to avoid initially failed reconciles when a Cluster references a ClusterClass which does not exist yet.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #