-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃尡 Move cluster webhook to top-level package #5518
馃尡 Move cluster webhook to top-level package #5518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for taking this up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgmt pending addressing comments above
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
d7973d2
to
0afdd42
Compare
Thx! |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: killianmuldoon kmuldoon@vmware.com
This PR moves the Cluster webhook to the new top-level webhooks package. It mirrors #5266 which created the top level package and moved the ClusterClass webhook to it.
This allows adding dependencies to the webhook without adding dependencies to the API package which is widely imported.
Fixes #5512
/area topology