Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Update CAPI version to v1beta1 in kustomization in test-framework #5526

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Oct 28, 2021

What this PR does / why we need it:
This PR updates the KubeadmControlPlane and KubeadmConfigTemplate version to v1beta1 in kustomization.yaml in test-framework to fix the conformance tests with k8s main branch in CAPA testgrid

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 28, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2021
@randomvariable
Copy link
Member

randomvariable commented Oct 28, 2021

/lgtm
/assign @sbueringer
/assign @CecileRobertMichon

This should fix the upgrading to main branch tests. Medium term we should probably generate this programatically somehow.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2021
@sbueringer
Copy link
Member

/lgtm

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit d72fd59 into kubernetes-sigs:main Oct 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Oct 28, 2021
@Ankitasw Ankitasw deleted the kubetest-v1beta1 branch November 1, 2021 12:13
@sbueringer
Copy link
Member

sbueringer commented Feb 8, 2022

/cherry-pick release-1.0
(let's discuss on the cherry-pick PR)

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #6080

In response to this:

/cherry-pick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants