-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Fix the typo in the json content #5527
Conversation
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find!
Is there any way to run linters on our tagged (yaml, json etc.) code blocks in our MD files? There could be a few more surprises like this for users.
/lgtm
I'm using markdownlint-cli2 in a downstream repository running in a Docker nodejs container. It would be possible to add that here too. That said, I suspect it wouldn't be able to catch this type of error as it would need support for language parsing/validation for multiple languages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Currently, there is an error in the JSON text mentioned in the developers' guide which needs to be fixed. As per json standard, there is no trailing comma is supported.
e.g:
After the fix:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #