🐛 restore - set tenants on the new object graph constructed from files in the backup directory

[varshavaradarajan]

What this PR does / why we need it:
While restore is pretty much works like move, the difference is the the object graph being constructed in move shows the uidToNode objects with the tenants set correctly (as does the backup command). However, with restore, since a new object graph is created, the tenant is not being set at on the restored object after reading the object from the backup directory. This leads restore to only restore the cluster object. I think the restore function is missing the o.setTenants call

Since the Test_objectMover_restore test uses getObjectGraph instead of creating a new graph like the actual restore does, I'm not sure if I need to add a test here.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5587

[k8s-ci-robot]

Welcome @varshavaradarajan!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @varshavaradarajan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fabriziopandini]

@ykakarap PTAL

[vincepri]

/ok-to-test

[fabriziopandini]

Also @jpmcb @stmcginnis

[enxebre]

/milestone v1.1
This seems a legit bugfix, @fabriziopandini do we want to backport to 1.0?

[k8s-ci-robot]

@enxebre: You must be a member of the kubernetes-sigs/cluster-api-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.1
This seems a legit bugfix, @fabriziopandini do we want to backport to 1.0?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ykakarap]

/lgtm

We should also consider adding some e2e tests to make sure that these bugs are caught early.

do we want to backport to 1.0?

I think we should. FYI, Release 0.4 also seems to have the same bug.

[vincepri]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[varshavaradarajan]

hey, is this going to be backported to Release 0.4 and 1.0?

[ykakarap]

I think it should be. @fabriziopandini thoughts?

[fabriziopandini]

/cherry-pick release-1.0

[k8s-infra-cherrypick-robot]

@fabriziopandini: new pull request created: #5626

In response to this:

/cherry-pick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.