🌱 Move Cluster and ClusterClass webhook implementation to top level package

[killianmuldoon]

Move the implementations of validation checks from the internal API package to the webhooks package. The webhooks package was previously calling the public methods in the API package which are deprecated and due to be removed in a future release.

Some details of the internal methods of the validation methods were changed in order to make this move.

Fixes #5594

[sbueringer]

Looks good overall. A few nits

[sbueringer]

lgtm +/- squash

[fabriziopandini]

only a tiny nit/question from my side, otherwise lgtm

[sbueringer]

Not sure about the long method receiver, I've never seen one >2 or maybe >3 characters. But not a blocker and I couldn't find any guidance/recommendations.

/lgtm

[killianmuldoon]

Not sure about the long method receiver, I've never seen one >2 or maybe >3 characters. But not a blocker and I couldn't find any guidance/recommendations.

Agreed it's not ideal or common - but I do think there's a risk of confusion here because of the type name (But it's the only way that makes sense when importing webhooks.Cluster).

[fabriziopandini]

/lgtm

[vincepri]

/approve
@killianmuldoon

cluster-api/api/v1beta1/cluster_webhook.go

Lines 49 to 50 in 30b8f68

	// Deprecated: This method is going to be removed in a next release.
	func (c *Cluster) Default() {

It'd be great if we can add a more specific depreacation message for folks that these have now moved here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment