Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Current implementation of topology reconcile logger always mutate the current logger when calling WithObject/WithRef/WithMachineDeployment in addition to returning a new one.
This could lead to values leaking in while we are doing multiple calls to those methods with different objects, e.g. in
cluster-api/controllers/topology/reconcile_state.go
Line 175 in 87be2ec
This PR removes the side effect, thus making the logger behaviour consistent to the original logr.Logger.