馃尡 Use internal/builders in tests for webhook package #5622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
killianmuldoon
commented
Nov 9, 2021
| @@ -252,7 +252,7 @@ func (webhook *Cluster) validateTopology(ctx context.Context, old, new *clusterv | |||
| allErrs = append( | |||
| allErrs, field.Invalid( | |||
| field.NewPath("spec", "topology", "class"), | |||
| new.Name, | |||
| new.Spec.Topology.Class, | |||
There was a problem hiding this comment.
This is a small bugfix to use the clusterClass name in this error message.
sbueringer
reviewed
Nov 10, 2021
killianmuldoon
force-pushed
the
test/add-builders-to-webhook-tests
branch
3 times, most recently
from
ae9e817
to
c3234a6
Compare
|
lgtm +/- squash |
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
killianmuldoon
force-pushed
the
test/add-builders-to-webhook-tests
branch
from
c3234a6
to
87afe7f
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: killianmuldoon kmuldoon@vmware.com
This updates the unit tests in the webhooks folder to use our test builders instead of raw structs. This will make it easier to create new tests for compatibility and variables in the webhooks package.
Fixes #5621