Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add Template compatibility checks to topology/checks package #5641

Merged
merged 1 commit into from
Nov 16, 2021
Merged

🌱 Add Template compatibility checks to topology/checks package #5641

merged 1 commit into from
Nov 16, 2021

Conversation

killianmuldoon
Copy link
Contributor

Signed-off-by: killianmuldoon kmuldoon@vmware.com

Add Template compatibility check functions to the Topology/checks package so they can be reused.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 11, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 11, 2021
@killianmuldoon killianmuldoon changed the title Add Template compatibility checks to topology/checks package 🌱 Add Template compatibility checks to topology/checks package Nov 11, 2021
@killianmuldoon killianmuldoon mentioned this pull request Nov 11, 2021
Merged
sbueringer
sbueringer reviewed Nov 12, 2021
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, a few nits

internal/topology/check/compatibility.go Show resolved Hide resolved
internal/topology/check/compatibility_test.go Outdated Show resolved Hide resolved
internal/topology/check/compatibility_test.go Show resolved Hide resolved
webhooks/clusterclass.go Outdated Show resolved Hide resolved
webhooks/clusterclass.go Outdated Show resolved Hide resolved
webhooks/clusterclass.go Outdated Show resolved Hide resolved
fabriziopandini
fabriziopandini reviewed Nov 12, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm apart some nit on naming / on avoiding duplicate logic

internal/topology/check/compatibility.go Outdated Show resolved Hide resolved
internal/topology/check/compatibility.go Outdated Show resolved Hide resolved
webhooks/clusterclass.go Outdated Show resolved Hide resolved
fabriziopandini
fabriziopandini reviewed Nov 12, 2021
View reviewed changes
internal/topology/check/compatibility.go Outdated Show resolved Hide resolved
internal/topology/check/compatibility.go Outdated Show resolved Hide resolved
internal/topology/check/compatibility.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 16, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 16, 2021 •
edited

CLA Signed

The committers are authorized under a signed CLA.

@killianmuldoon
Copy link
Contributor Author

/retest

fabriziopandini
fabriziopandini reviewed Nov 16, 2021
View reviewed changes
internal/topology/check/compatibility_test.go Outdated Show resolved Hide resolved
internal/topology/check/compatibility.go Outdated Show resolved Hide resolved
internal/topology/check/compatibility.go Outdated Show resolved Hide resolved
internal/topology/check/compatibility.go Outdated Show resolved Hide resolved
fabriziopandini
fabriziopandini reviewed Nov 16, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2021
sbueringer
sbueringer reviewed Nov 16, 2021
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits

controllers/topology/reconcile_state.go Outdated Show resolved Hide resolved
internal/topology/check/compatibility.go Outdated Show resolved Hide resolved
internal/topology/check/compatibility.go Outdated Show resolved Hide resolved
internal/topology/check/compatibility.go Outdated Show resolved Hide resolved
internal/topology/check/compatibility.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2021
@killianmuldoon
Add Template compatibility checks to topology/checks package
ffc0379 
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>

fix naming issues etc.
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2021
@fabriziopandini
Copy link
Member

Great work!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9d569fb into kubernetes-sigs:main Nov 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@killianmuldoon @sbueringer @fabriziopandini @k8s-ci-robot