Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 Update prerequisites for installing Metal3 provider #5642

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

fmuyassarov
Copy link
Member

What this PR does / why we need it:
From release v0.5.0 of Cluster-api-provider-metal3, the following
environment variables don't need to be exported because Baremetal
Operator is now decoupled from CAPM3. Instead, they need to be
exported when installing Baremetal Operator manually (not via
clusterctl).

From release v0.5.0 of Cluster-api-provider-metal3, the following
environment variables don't need to be exported because Baremetal
Operator is now decoupled from CAPM3. Instead, they need to be
exported when installing Baremetal Operator manually (not via
clusterctl).
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 11, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @fmuyassarov. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 11, 2021
@fmuyassarov
Copy link
Member Author

/cc @kashifest

@k8s-ci-robot
Copy link
Contributor

@fmuyassarov: GitHub didn't allow me to request PR reviews from the following users: kashifest.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kashifest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 11, 2021
@fmuyassarov
Copy link
Member Author

/cc @fabriziopandini

@sbueringer
Copy link
Member

sbueringer commented Nov 11, 2021

/ok-to-test

If I got it correctly the metal3 provider before v0.5 (aka v0.4) is compliant with the CAPI v1alpha3 contract?

I'm not sure in which versions of the book this comment should be added.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 11, 2021
@fmuyassarov
Copy link
Member Author

/ok-to-test

If I got it correctly the metal3 provider before v0.5 (aka v0.4) is compliant with the CAPI v1alpha3 contract?

I'm not sure in which versions of the book this comment should be added.

Yes. Here is the compatibility table

| CAPM3 version | Cluster API version | CAPM3 Release |
|---------------|---------------------|---------------|
| v1alpha4      | v1alpha3            | v0.4.X        |
| v1alpha5      | v1alpha4            | v0.5.X        |
| v1beta1       | v1beta1             | v1.0.X        |

As such, I will need to backport it to release-0.4 branch (CAPI v1a4 & CAPM3 v1alpha5).

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2021
@fmuyassarov
Copy link
Member Author

/cc @vincepri

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fabriziopandini
Copy link
Member

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2021
@fabriziopandini
Copy link
Member

/cherry-pick release-1.0
given that this can avoid user problems

@k8s-infra-cherrypick-robot

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.0 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.0
given that this can avoid user problems

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@fabriziopandini: new pull request created: #5655

In response to this:

/cherry-pick release-1.0
given that this can avoid user problems

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fmuyassarov
Copy link
Member Author

@fabriziopandini thank you very much for the cherry-pick and review.

@fmuyassarov fmuyassarov deleted the udpate-metal3/feruz branch November 12, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants