-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃摉 Update prerequisites for installing Metal3 provider #5642
Conversation
From release v0.5.0 of Cluster-api-provider-metal3, the following environment variables don't need to be exported because Baremetal Operator is now decoupled from CAPM3. Instead, they need to be exported when installing Baremetal Operator manually (not via clusterctl).
Hi @fmuyassarov. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @kashifest |
@fmuyassarov: GitHub didn't allow me to request PR reviews from the following users: kashifest. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @fabriziopandini |
/ok-to-test If I got it correctly the metal3 provider before v0.5 (aka v0.4) is compliant with the CAPI v1alpha3 contract? I'm not sure in which versions of the book this comment should be added. |
Yes. Here is the compatibility table
As such, I will need to backport it to release-0.4 branch (CAPI v1a4 & CAPM3 v1alpha5). |
/lgtm |
/cc @vincepri |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.0 |
@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.0 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@fabriziopandini: new pull request created: #5655 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@fabriziopandini thank you very much for the cherry-pick and review. |
What this PR does / why we need it:
From release v0.5.0 of Cluster-api-provider-metal3, the following
environment variables don't need to be exported because Baremetal
Operator is now decoupled from CAPM3. Instead, they need to be
exported when installing Baremetal Operator manually (not via
clusterctl).