Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add ClusterClass changes e2e test #5664

Merged
merged 1 commit into from
Nov 23, 2021
Merged

✨ Add ClusterClass changes e2e test #5664

merged 1 commit into from
Nov 23, 2021

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Nov 15, 2021 •
edited

What this PR does / why we need it:

This PR adds an e2e test which verifies that changes to the ClusterClass and ClusterClass rebases are rolled out correctly.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 15, 2021
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer sbueringer changed the title [WIP] Add ClusterClass changes e2e test [WIP] ✨ Add ClusterClass changes e2e test Nov 15, 2021
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member Author

/retest

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

sbueringer
sbueringer commented Nov 17, 2021
View reviewed changes
webhooks/cluster.go Outdated
),
)
}
// FIXME(before merge): can be removed when https://github.com/kubernetes-sigs/cluster-api/pull/5644 has been merged.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be rolled back before merge after #5644 has been merged

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member Author

/test pull-cluster-api-test-mink8s-main
unit test flake

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 18, 2021
@sbueringer sbueringer changed the title [WIP] ✨ Add ClusterClass changes e2e test ✨ Add ClusterClass changes e2e test Nov 18, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2021
@sbueringer
Copy link
Member Author

/hold
until #5644 is merged and I can drop the hack in the webhook

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2021
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member Author

Tests fail because main is broken right now

@sbueringer
Copy link
Member Author

Fix merged, should work now:
/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2021
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member Author

sbueringer commented Nov 22, 2021 •
edited

/test pull-cluster-api-e2e-full-main

Rebased on top of main after the upgrade PR has been merged.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 22, 2021
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

1 similar comment
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

fabriziopandini
fabriziopandini reviewed Nov 23, 2021
View reviewed changes
test/e2e/clusterclass_changes_test.go Outdated Show resolved Hide resolved
test/e2e/clusterclass_changes_test.go Outdated Show resolved Hide resolved
test/e2e/clusterclass_changes.go Outdated Show resolved Hide resolved
test/e2e/clusterclass_changes.go Outdated Show resolved Hide resolved
test/e2e/clusterclass_changes.go Outdated Show resolved Hide resolved
test/e2e/clusterclass_changes.go Show resolved Hide resolved
test/e2e/clusterclass_changes.go Show resolved Hide resolved
test/e2e/clusterclass_changes.go Show resolved Hide resolved
test/e2e/clusterclass_changes.go Outdated Show resolved Hide resolved
test/e2e/clusterclass_changes.go Show resolved Hide resolved
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@fabriziopandini Thx for the review, should be fixed/answered PTAL.

@sbueringer
Add ClusterClass changes e2e test
baa09c3 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 23, 2021
@sbueringer
Copy link
Member Author

sbueringer commented Nov 23, 2021 •
edited

/test pull-cluster-api-e2e-full-main

@fabriziopandini Should be fixed, I hope I found every occurrence.

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 68b66fa into kubernetes-sigs:main Nov 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Nov 23, 2021
@sbueringer sbueringer deleted the pr-clusterclass-rollout-test branch November 23, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sbueringer @fabriziopandini @k8s-ci-robot